frontend: avoid a duplicated "exists" check #3472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit 609d369 only partly resolved the TOCTOU effects (which we are not fixing here either). The problem being fixed now is that we duplicated the duplication check, - once in the `validate_on_submit()`, then - using the `add(check_for_duplicates=True)`. The later check is wrong though, because it raises an exception that is not handled properly (exist_ok=True ignored). Complements: fdff0c8 Complements: 609d369 Fixes: fedora-copr#3471
|
@FrostyX do you think I can hot-fix this in prod? |
|
I mean, this frontend's code deserves a major cleanup IMVHO - namely I think this commit brings in some dead code. But the commit here seems relatively simple so we could do more things in a separate PR. |
FrostyX
approved these changes
Oct 10, 2024
We discussed it off-list but just FTR, I ACKed this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 609d369 only partly resolved the TOCTOU effects (which we are not fixing here either). The problem being fixed now is that we duplicated the duplication check,
validate_on_submit(), thenadd(check_for_duplicates=True). The later check is wrong though, because it raises an exception that is not handled properly (exist_ok=True ignored).Complements: fdff0c8
Complements: 609d369
Fixes: #3471