Configurable storage for new projects #3402
Conversation
FrostyX
force-pushed
the
default-storage
branch
2 times, most recently
from
7d208bd to
406574f
Compare
| storage = wtforms.SelectField( | ||
| "Admin only - what storage should be set for new projects", | ||
| choices=[(x, x) for x in ["backend", "pulp"]], | ||
| validators=[wtforms.validators.Optional()], | ||
| ) | ||
|
|
There was a problem hiding this comment.
Can we hide this option for normal users so they can't see it?
There was a problem hiding this comment.
I may have missed something but users shouldn't see it already. When creating/editing a project in the web UI, the option shouldn't be there for either admins or normal users. For API, it will probably have to be visible?
Also, I just realized that I forgot to add the field into the API schema and it works regardless. Is this expected @nikromen? I will add it though :-)
There was a problem hiding this comment.
I will add it though :-)
Done
python/copr/v3/proxies/project.py
Outdated
| @@ -110,6 +110,7 @@ def add(self, ownername, projectname, chroots, description=None, instructions=No | |||
| enabled together with this project repository. | |||
| :param list packit_forge_projects_allowed: List of forge projects that | |||
| will be allowed to build in the project via Packit | |||
| :param str storage: What storage should be set for new projects | |||
There was a problem hiding this comment.
Please add here the comment about admin only action too
There was a problem hiding this comment.
Also I can see that in cli and frontend there are choices between pulp and BE. Can we somehow here check whether this is also storage enum or some typo nonsense?
There was a problem hiding this comment.
Please add here the comment about admin only action too
Good idea, I will mention it.
Can we somehow here check whether this is also storage enum or some typo nonsense?
That would be a precedent because so far we don't have validation for any fields in python-copr, only in CLI and then on frontend. Having validation there could be nice if the code could be shared between python-copr and copr-cli but I don't like the idea of duplicating the validation code on yet another place.
There was a problem hiding this comment.
Please add here the comment about admin only action too
Done
FrostyX
force-pushed
the
default-storage
branch
from
406574f to
e82e5bb
Compare
See fedora-copr#2533 This will be useful for beaker tests where we can now add basic tests for every supported storage.
FrostyX
force-pushed
the
default-storage
branch
from
e82e5bb to
a2622b2
Compare
See #2533