Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: use the same repofile for all CentOS Stream versions #3341

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

nforro
Copy link
Contributor

@nforro nforro commented Jul 24, 2024

Fixes #3334.

m4.os_version = "9"

test_sets.extend([
dict(args=(m4, http_url),

Check warning

Code scanning / vcs-diff-lint

TestHelpers.test_generate_repo_url: Consider using '{"args": (m4, http_url), "expected": 'http://example.com/path/centos-stream-$releasever-$basearch/', ... }' instead of a call to 'dict'. Warning test

TestHelpers.test_generate_repo_url: Consider using '{"args": (m4, http_url), "expected": 'http://example.com/path/centos-stream-$releasever-$basearch/', ... }' instead of a call to 'dict'.
test_sets.extend([
dict(args=(m4, http_url),
expected="http://example.com/path/centos-stream-$releasever-$basearch/"),
dict(args=(m4, https_url),

Check warning

Code scanning / vcs-diff-lint

TestHelpers.test_generate_repo_url: Consider using '{"args": (m4, https_url), "expected": 'https://example.com/path/centos-stream-$releasever-$basearch/', ... }' instead of a call to 'dict'. Warning test

TestHelpers.test_generate_repo_url: Consider using '{"args": (m4, https_url), "expected": 'https://example.com/path/centos-stream-$releasever-$basearch/', ... }' instead of a call to 'dict'.
Copy link
Member

@praiskup praiskup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@praiskup praiskup merged commit b9b5cf8 into fedora-copr:main Jul 26, 2024
6 of 7 checks passed
@lsm5
Copy link

lsm5 commented Jul 30, 2024

@praiskup mind if I ask ETA on deployment of this patch? :)

@nforro nforro deleted the cs-releasever branch July 30, 2024 13:56
@FrostyX
Copy link
Member

FrostyX commented Jul 30, 2024

The patch is simple enough, I am thinking about hotfixing it in production, WDYT @praiskup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL redirect for centos stream does not work correctly
4 participants