backend: remove fake jobs and pass specific arguments to storage calls #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
FrostyX
force-pushed
the
pulp-remove-fake-jobs
branch
2 times, most recently
from
9ebe686 to
4711cac
Compare
FrostyX
force-pushed
the
pulp-remove-fake-jobs
branch
6 times, most recently
from
1a08a33 to
90ca16e
Compare
There is one small exception and that is `publish_repository` which takes `**kwargs` for parameters that differ across storages.
The previous code "worked" only by an accident. Previously we called the publication endpoint without a trailing slash (changed in d8013c), which caused some weird redirect and returned a list of all publications, not the one created publication that I expected. We need to manually query the publication href from the submitted task.
The reasoning for doing so was based on a wrong premise. > The standard urlencode would change the slashes to %2F making Pulp to > not find the project when filtering by name. The reason why Pulp couldn't find any project wasn't becaues of encoded slashes but because of a bug that I fixed in cc12c9.
FrostyX
force-pushed
the
pulp-remove-fake-jobs
branch
from
90ca16e to
7a75f2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one small exception and that is
publish_repositorywhich takes**kwargsfor parameters that differ across storages.