Implement chroot deletion in Pulp #3312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praiskup
reviewed
Jun 25, 2024
backend/copr_backend/actions.py
Outdated
| ownername = ext_data["ownername"] | ||
| projectname = ext_data["projectname"] | ||
| chrootname = ext_data["chrootname"] | ||
| storage = storage_for_enum(ext_data["storage"], self.opts, self.log) |
There was a problem hiding this comment.
This reminds me the note from previous PR, that having something like:
storage = CoprResultStorage(ext_data["ownername"], ext_data["project_name"])
storage.delete_repository(ext_data["dirname"])
Would be much more convenient. Maybe even:
storage = copr.get_storage()
This isn't necessary and we could get by with `storage_for_job` but I think this is a good first step towards decoupling storage from jobs, as we discoused a couple of times already.
FrostyX
force-pushed
the
pulp-disabling-chroots
branch
from
b810e0f to
6ffb365
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
FrostyX
force-pushed
the
pulp-disabling-chroots
branch
from
6ffb365 to
01a9bcc
Compare
|
Oops, some failing tests |
FrostyX
force-pushed
the
pulp-disabling-chroots
branch
from
01a9bcc to
9e09c77
Compare
praiskup
reviewed
Jun 26, 2024
| self.destdir = self.opts.destdir | ||
| self.front_url = self.opts.frontend_base_url | ||
| self.results_root_url = self.opts.results_baseurl | ||
|
|
||
| self.log = log if log else get_redis_logger(self.opts, "backend.actions", "actions") | ||
|
|
||
| storage_enum = StorageEnum.backend | ||
| if isinstance(self.ext_data, dict) and "storage" in self.ext_data: | ||
| storage_enum = self.ext_data.get("storage") |
There was a problem hiding this comment.
Ah, we are on backend - not frontend :-( so we do not have the models.Action object in hand...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3306