backend: add support for pulp domains #3311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
The pulp.stage.devshift.net currently gives me 500 error when trying to upload an artifact, so I couldn't properly test this yet. |
praiskup
reviewed
Jul 4, 2024
| self.config["api_root"], | ||
| domain, | ||
| endpoint, | ||
| ])) |
There was a problem hiding this comment.
Since we use os.path for urls already (sub-optimal), don't you want to use os.path.join()?
There was a problem hiding this comment.
The problem with os.path.join is that it does something like this:
>>> os.path.join("/foo/", "/bar/", "/baz/")
'/baz/'while the "/".join variant produces something more expected
ipdb> os.path.normpath("/".join(["/foo/", "/bar/", "/baz/"]))
'/foo/bar/baz'
praiskup
reviewed
Jul 4, 2024
|
|
||
| # Normpath removes the trailing slash. If it was there, put it back | ||
| if endpoint[-1] == "/": | ||
| relative += "/" |
There was a problem hiding this comment.
os.path.join() preserves trailing slashes
The pulp.stage.devshift.net instance has domains enabled while our STG instance has them disabled. As long as it is easy to support both cases, I'd do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pulp.stage.devshift.net instance has domains enabled while our STG instance has them disabled. As long as it is easy to support both cases, I'd do that.