Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpmbuild, dist-git-client: new package dist-git-client #3299

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

praiskup
Copy link
Member

@praiskup praiskup commented Jun 6, 2024

The dist-git-client utility seems generic enough to have it built separately. This could be useful e.g. for the Konflux build initiative, where we don't necessarily have to build the full copr-rpmbuild package to operate with DistGit.

@praiskup praiskup force-pushed the praiskup-dist-git-client branch from e70f68c to 9881153 Compare June 6, 2024 08:14
@praiskup
Copy link
Member Author

praiskup commented Jun 6, 2024

Sorry, I thought this will be very easy, and eventually I spend on this like 2 hours :) but seems still worth it.

I'd be curious what you would say if we moved the new package into the dist-git repository.

@praiskup praiskup force-pushed the praiskup-dist-git-client branch 3 times, most recently from 15f3fbf to 80272dc Compare June 6, 2024 11:14
@FrostyX
Copy link
Member

FrostyX commented Jun 6, 2024

I'd be curious what you would say if we moved the new package into the dist-git repository.

I haven't done a full review yet but that sounds like a good idea to me

praiskup added a commit to praiskup/dist-git that referenced this pull request Jun 12, 2024
Inherited from Copr basecode, namely starting from
fedora-copr/copr#3299
praiskup added a commit to praiskup/dist-git that referenced this pull request Jun 12, 2024
Inherited from Copr basecode, namely starting from
fedora-copr/copr#3299
@praiskup
Copy link
Member Author

I haven't done a full review yet but that sounds like a good idea to me

Ok, I remove the dist-git-client code in a separate client, and created a PR against the dist-git project: release-engineering/dist-git#63

praiskup added 3 commits June 12, 2024 09:55
The dist-git-client utility seems generic enough to have it built
separately.  This could be useful e.g. for the Konflux build initiative,
where we don't necessarily have to build the full copr-rpmbuild package
to operate with DistGit.
This is a Python 3-only package.
@praiskup praiskup force-pushed the praiskup-dist-git-client branch from f6069c1 to 51c0c3e Compare June 12, 2024 07:55
FrostyX pushed a commit to release-engineering/dist-git that referenced this pull request Jun 19, 2024
Inherited from Copr basecode, namely starting from
fedora-copr/copr#3299
@praiskup
Copy link
Member Author

The package review goes here: https://bugzilla.redhat.com/show_bug.cgi?id=2293067

@praiskup
Copy link
Member Author

This has +1, dist-git-client is in updates-testing: https://bodhi.fedoraproject.org/updates/?search=dist-git-client

Merging, thank you for the review!

@praiskup praiskup merged commit 571c31c into fedora-copr:main Jun 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants