frontend: opt-in the log-detective.com button #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrostyX
reviewed
Mar 3, 2024
| # Whether we want to show the green "Feed Log-detective.com" button for | ||
| # failed builds. Currently only integrated with the Fedora Copr instance. | ||
| #LOG_DETECTIVE_FEED = False | ||
|
|
There was a problem hiding this comment.
Nitpick but I don't like the LOG_DETECTIVE_FEED name because of the "feed" part. It can be easily confused with a feed in the sense of RSS feed, news feed, social media feed, etc.
I'd prefer something like LOG_DETECTIVE, LOG_DETECTIVE_INTEGRATION, LOG_DETECTIVE_ENABLED, LOG_DETECTIVE_BUTTON.
There was a problem hiding this comment.
Going with LOG_DETECTIVE_BUTTON then :) we can call it "_INTEGRATION" in the future once we have more "integration" than this.
praiskup
force-pushed
the
praiskup-log-detective-feed-optional
branch
from
3147b21 to
5ce6e1f
Compare
FrostyX
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.