frontend: Add backref relationship between Package and Build to silence sqlalchemy warnings #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nikromen
force-pushed
the
foreign-key-warning
branch
from
c319ac6 to
a11acf1
Compare
|
Is the testsuite failing because of the change? |
|
We already have this class Package(db.Model, helpers.Serializer, CoprSearchRelatedData):
...
builds = db.relationship("Build", order_by="Build.id")which IMHO causes the collision |
nikromen
force-pushed
the
foreign-key-warning
branch
from
a11acf1 to
ff8ae32
Compare
Yes, thank you. Unluckily... I cannot make alembic work locally on my machine to make migration. Could it somehow be because of the move to F39? |
What does it mean? A traceback, or ...? |
|
When I run |
... to silence sqlalchemy warnings The Package.builds column is used only for read only purposes and needs to be ordered accordingly against Build.id. Removing viewonly=True parameter and making it read-write column will result in errors since the relationship is used only for loading objects and not for any persistence operation. Setting the relationship to read-write would result in errors since the relationship.sync_backref flag is set to True and sqlalchemy tries then to sync the Package.builds column which was never commited - thus "This session is in 'committed' state; no further SQL can be emitted within this transaction." will appear.
|
Fixed that, pelase look to commit message for explanation |
nikromen
force-pushed
the
foreign-key-warning
branch
from
ff8ae32 to
876983a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2445