Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packit 400 errors #3471

Closed
praiskup opened this issue Oct 10, 2024 · 1 comment · Fixed by #3472
Closed

Packit 400 errors #3471

praiskup opened this issue Oct 10, 2024 · 1 comment · Fixed by #3472
Assignees
@praiskup

Comments

@praiskup
Copy link
Member

Follow up for #3372 and #3443. Now we get error 400 sometimes.
@github-project-automation github-project-automation bot moved this to Needs triage in CPT Kanban Oct 10, 2024
praiskup added a commit to praiskup/copr that referenced this issue Oct 10, 2024
@praiskup
frontend: avoid a duplicated "exists" check
50d24d3 
The commit 609d369 only partly resolved
the TOCTOU effects (which we are not fixing here either).  The problem
being fixed now is that we duplicated the duplication check,
- once in the `validate_on_submit()`, then
- using the `add(check_for_duplicates=True)`.
The later check is wrong though, because it raises an exception that is
not handled properly (exist_ok=True ignored).

Complements: fdff0c8
Complements: 609d369
Fixes: fedora-copr#3471
@praiskup praiskup mentioned this issue Oct 10, 2024
Merged
@praiskup
Copy link
Member Author

Hot-fixed in production.

@praiskup praiskup self-assigned this Oct 10, 2024
@praiskup praiskup moved this from Needs triage to In Progress in CPT Kanban Oct 10, 2024
@nikromen nikromen moved this from In Progress to Done in CPT Kanban Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@praiskup praiskup

Labels
None yet
Projects
CPT Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

frontend: avoid a duplicated "exists" check praiskup/copr
1 participant
@praiskup