Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when an RPM does not have compliant license #3290

Open
xsuchy opened this issue May 29, 2024 · 4 comments
Open

Warn when an RPM does not have compliant license #3290

xsuchy opened this issue May 29, 2024 · 4 comments
Labels
RFE Enhancement, feature requests

Comments

@xsuchy
Copy link
Member

xsuchy commented May 29, 2024

The work of migrating packages to SPDX is almost finished. We can call license-validate on the License tag of the resulting packages and check if licenses are compliant with Fedora policy.

When the license is not valid, we can show the user a warning that the license is not allowed. Or it has a typo - this will be common in the early days.

@befeleme
Copy link
Contributor

FYI: pyp2spec 0.10.0, released today, will no longer error when encountering a non-compliant license.

@brianjmurrell
Copy link

FYI: pyp2spec 0.10.0, released today, will no longer error when encountering a non-compliant license.

Awesome! What has to happen next for this to be the case in COPR?

@befeleme
Copy link
Contributor

First is has to land in all Fedora repositories (soon, up to 7 dayss: https://bodhi.fedoraproject.org/updates/?packages=pyp2spec)
Then, once this PR #3473 is merged, it'll be automatically pulled and invoked correctly in Copr.

@FrostyX
Copy link
Member

FrostyX commented Oct 11, 2024

Then, once this PR #3473 is merged, it'll be automatically pulled and invoked correctly in Copr.

Yes and no. AFAIK pyp2spec is not being automatically updated to the latest version on Copr builders so we will have to update it (easyfix) and we need to get the PR #3473 code into production. Since it is a one-liner, we don't have to wait for a new release and we can hotfix this in production.

Can you please ping us @befeleme once we should do this? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFE Enhancement, feature requests
Projects
Status: In 2 years
Development

No branches or pull requests

5 participants