Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if the detected license isn't a valid SPDX, don't error #47

Closed
befeleme opened this issue May 31, 2024 · 4 comments
Closed

Warn if the detected license isn't a valid SPDX, don't error #47

befeleme opened this issue May 31, 2024 · 4 comments

Comments

@befeleme
Copy link
Owner

When Copr adds a license-validate check to its repositories, pyp2spec doesn't have to be so strict in the automatic mode anymore: fedora-copr/copr#3290

Only warning should be sufficient for the human user, whom we expect to review the generated specfile anyway.

@trixirt
Copy link

trixirt commented Jun 20, 2024

The fedora-review will catch these problems so it is not necessary to error out.

@brianjmurrell
Copy link

Clearly something needs to happen here. Waiting for upstreams to fix metadata problems in their packages before COPR will successfully build them is just unworkable. I have been waiting literally weeks (if not months) for an upstream to simply fix their SPDX licence and it's still not done, making this package unbuildable in COPR.

@hroncok
Copy link
Contributor

hroncok commented Jun 20, 2024

You don't need to use automatic pyp2spec conversion to build the package in copr.

@brianjmurrell
Copy link

I do if I want to use Anitya autorebuild on it and pyp2rpm fails to build the package.

Apart from the SPDX license barf, pyp2spec builds the package fine.

befeleme added a commit that referenced this issue Sep 26, 2024
Also, remove -l CLI option to provide the license manually.
Whoever needs that, can edit the resulting specfile.

Fixes: #47
befeleme added a commit that referenced this issue Sep 26, 2024
Also, remove -l CLI option to provide the license manually.
Whoever needs that, can edit the resulting specfile.

Fixes: #47
befeleme added a commit that referenced this issue Sep 26, 2024
Also, remove -l CLI option to provide the license manually.
Whoever needs that, can edit the resulting specfile.

Fixes: #47
befeleme added a commit that referenced this issue Oct 1, 2024
Also, remove -l CLI option to provide the license manually.
Whoever needs that, can edit the resulting specfile.

Fixes: #47
befeleme added a commit that referenced this issue Oct 1, 2024
Also, remove -l CLI option to provide the license manually.
Whoever needs that, can edit the resulting specfile.

Fixes: #47
befeleme added a commit that referenced this issue Oct 1, 2024
Also, remove -l CLI option to provide the license manually.
Whoever needs that, can edit the resulting specfile.

Fixes: #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants