-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if the detected license isn't a valid SPDX, don't error #47
Comments
The fedora-review will catch these problems so it is not necessary to error out. |
Clearly something needs to happen here. Waiting for upstreams to fix metadata problems in their packages before COPR will successfully build them is just unworkable. I have been waiting literally weeks (if not months) for an upstream to simply fix their SPDX licence and it's still not done, making this package unbuildable in COPR. |
You don't need to use automatic pyp2spec conversion to build the package in copr. |
I do if I want to use Anitya autorebuild on it and Apart from the SPDX license barf, |
Also, remove -l CLI option to provide the license manually. Whoever needs that, can edit the resulting specfile. Fixes: #47
Also, remove -l CLI option to provide the license manually. Whoever needs that, can edit the resulting specfile. Fixes: #47
Also, remove -l CLI option to provide the license manually. Whoever needs that, can edit the resulting specfile. Fixes: #47
Also, remove -l CLI option to provide the license manually. Whoever needs that, can edit the resulting specfile. Fixes: #47
Also, remove -l CLI option to provide the license manually. Whoever needs that, can edit the resulting specfile. Fixes: #47
Also, remove -l CLI option to provide the license manually. Whoever needs that, can edit the resulting specfile. Fixes: #47
When Copr adds a license-validate check to its repositories, pyp2spec doesn't have to be so strict in the automatic mode anymore: fedora-copr/copr#3290
Only warning should be sufficient for the human user, whom we expect to review the generated specfile anyway.
The text was updated successfully, but these errors were encountered: