-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the token back as an optional argument that is fetched dynamically. #45
Conversation
If the tokenURL has to be supplied by the RP, that feels like an arbitrary difference vs "full" FedCM. Is there any reason we don't want to just use the existing configURL mechanism? |
I considered using the whole configURL mechanism. The biggest piece is that we don't need the protections offered by the I realized while writing this that a better place to put this is in the IDP's store, which is more equivalent to the configURL. Change made. |
388a506
to
34bab06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Human-facing, should be editorial.
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Is tokenUrl the same as the id_assertion_endpoint? |
Exactly! Maybe it would be better to rename it to idAssertionURL? |
It is a little ugly, but I think conceptually right :) |
Aiming to resolve #42