Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coalesce error in ofec_filings_all_mv #5424

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

hcaofec
Copy link
Contributor

@hcaofec hcaofec commented Apr 24, 2023

Summary (required)

Fix the coalesce error.

Required reviewers

1 developer

How to test

  1. Download feature branch
  2. Run pytest
  3. Run Flyway migrate
  4. Test filings endpoint on local by switching model to tmp mv

In common/models/filings.py, set

class Filings(FecFileNumberMixin, CsvMixin, db.Model):
tablename = 'ofec_filings_all_mv_tmp_hc'

Before change, no rows returned
https://api.open.fec.gov/v1/filings/?sort=-receipt_date&sort_hide_null=false&sort_nulls_last=false&per_page=20&page=1&sort_null_only=false&q_filer=C00780197&api_key=DEMO_KEY
After change, 9 rows returned
http://127.0.0.1:5000/v1/filings/?page=1&sort_nulls_last=false&q_filer=C00780197&sort=-receipt_date&sort_hide_null=false&per_page=20&sort_null_only=false

Copy link
Contributor

@fec-jli fec-jli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix null committee_name in ts_vector column used by q_filer
2 participants