Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for strictStorage #117

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DaddyWarbucks
Copy link
Contributor

@DaddyWarbucks DaddyWarbucks commented May 21, 2022

Fixes: #116

Copy link
Member

@marshallswain marshallswain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daffl can give final word. Looks like we can :shipit:

@DaddyWarbucks
Copy link
Contributor Author

I did end up testing and using this by extending the service in my own project and it works well 👍

@DaddyWarbucks
Copy link
Contributor Author

On another note, I also have an implementation that uses comlink and idb-keyval for some cool service worker based offline storage. But, it serves a bit of a different purpose and I am not resetting the store like the code for this PR does. It is more for "offline first" than "offline backup". For the app that it is implemented in, everything is kept in memory for speed purposes. I left the actual methods (and filtering the list) on the main thread due to how service workers can actually double memory footprint. But, the storage on the service worker size does a bunch of compression via compress-json and some other offthread niceties. Maybe its worth some ServiceWorkerService in this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service keeps all records in memory
2 participants