Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feather Atomic PR to open commentary #203

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

BrandyJSon
Copy link

Atomic swap plugin for feather.

twiddle and others added 29 commits May 18, 2024 12:49
// TODO Later
Add in Browse button
Add ui reflection of download progess/occuring
Bump to swap tool v 0.13.1

** Fix to kill swap process & monero-wallet-rpc process on shutdown
… -> xmr stagenet atomic swaps. Making testing much more practical.
…ed AtomicSwap functionality to clean swap and monero-wallet-rpc. Can run swap successfully if nothing goes wrong.

TODO:
…ed AtomicSwap functionality to clean swap and monero-wallet-rpc. Can run swap successfully if nothing goes wrong. Cleaned some code

TODO:
     1. Connect signals to make status of swap reflected in AtomicSwap dialog
     2. Add informational tabs to AtomicSwap dialog
     3. Add cancel and refund functionality to AtomicSwap when things go wrong, possibly add automatic cancel functionality
     1. Connect signals to make status of swap reflected in AtomicSwap dialog
     2. Add informational tabs to AtomicSwap dialog
TODO:
     3. Add cancel and refund functionality to AtomicSwap when things go wrong, possibly add automatic cancel functionality
     4. Add History and recovery to atomic window
     1. Connect signals to make status of swap reflected in AtomicSwap dialog
     2. Add informational tabs to AtomicSwap dialog
     4. Add recovery to atomic widget
TODO:
     3. Add cancel and refund functionality to AtomicSwap when things go wrong
     4. Refactor AtomicWidget so AtomicSwap handles parsing of swap binary output.
     1. Connect signals to make status of swap reflected in AtomicSwap dialog
     2. Add informational tabs to AtomicSwap dialog
     4. Add recovery to atomic widget
     5. Refactor AtomicWidget so AtomicSwap handles parsing of swap binary output.
TODO:
     3. Add cancel and refund functionality to AtomicSwap when things go wrong
…ttings based on feather configuration.

Atomic will no longer appear if feather is launched in testnet mode.
DONE:
     1. Connect signals to make status of swap reflected in AtomicSwap dialog
     2. Add informational tabs to AtomicSwap dialog
     4. Add recovery to atomic widget
     5. Refactor AtomicWidget so AtomicSwap handles parsing of swap binary output.
TODO:
     3. Add cancel and refund functionality to AtomicSwap when things go wrong
DONE:
     1. Connect signals to make status of swap reflected in AtomicSwap dialog
     2. Add informational tabs to AtomicSwap dialog
     3. Add cancel and refund functionality to AtomicSwap when things go wrong
     4. Add recovery to atomic widget
     5. Refactor AtomicWidget so AtomicSwap handles parsing of swap binary output.
TODO:
     Test for bugs, make custom readme, build for other systems
Everything should be working, tested on ubuntu.
Refactor libarchive linking and add to guix manifest

Fix toolchain

Patch 2

Patch 3

Patch 4

Patch 5

Patch 6

patch 7

Patch 8

Patch 9

Patch 11
Include demo and info about usage
Added a over clearnet checkbox to force the swap tool into listing sellers without tor. This is a temporary fix till comit xmr<->btc maintainers can update libp2p version.
Add back libarchive to guix package post merge
Copy link
Contributor

@tobtoht tobtoht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick comments.

CMakeLists.txt Outdated Show resolved Hide resolved
contrib/depends/packages/libarchive.mk Outdated Show resolved Hide resolved
contrib/guix/manifest.scm Outdated Show resolved Hide resolved
external/feather-docs Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A svg file would be preferable. Perhaps you can find a similar one on https://www.svgrepo.com/ ?

src/plugins/atomic/AtomicConfigDialog.cpp Outdated Show resolved Hide resolved
src/wizard/WalletWizard.cpp Outdated Show resolved Hide resolved
src/plugins/atomic/AtomicConfigDialog.cpp Outdated Show resolved Hide resolved
src/plugins/atomic/AtomicWidget.cpp Outdated Show resolved Hide resolved
src/utils/config.cpp Outdated Show resolved Hide resolved
@MajesticBank
Copy link

+1 for this trust-less and easy way to get into monero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants