-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entity equipment #495
base: main
Are you sure you want to change the base?
Entity equipment #495
Conversation
Fixed typo, added comment
Missing features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this isn't done, just wanted to suggest a change.
Awesome work so far, I just have one suggestion that should help prevent bugs since there is a requirement on the struct that cannot be enforced at the type level and thus needs to be enforced manually.
Implemented safe EntityEquipment constructor Removed handle_held_item_change() test
Can you write "Closes #494" so github gets the idea about automatically closing the issue? |
Entity equipment
Status
Description
This PR implements entity equipment packets (i.e. armor, items in the main hand and off-hand).
Related issues
Closes #494
Checklist
cargo fmt
,cargo clippy --all-targets
,cargo build --release
andcargo test
and fixed any generated errors!Note: if you locally don't get any errors, but GitHub Actions fails (especially at
clippy
) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.