Entity equipment #495
Draft
Entity equipment #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed typo, added comment
|
Missing features:
|
ambeeeeee
reviewed
Sep 28, 2021
There was a problem hiding this comment.
I know this isn't done, just wanted to suggest a change.
Awesome work so far, I just have one suggestion that should help prevent bugs since there is a requirement on the struct that cannot be enforced at the type level and thus needs to be enforced manually.
Implemented safe EntityEquipment constructor Removed handle_held_item_change() test
|
Can you write "Closes #494" so github gets the idea about automatically closing the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entity equipment
Status
Description
This PR implements entity equipment packets (i.e. armor, items in the main hand and off-hand).
Related issues
Closes #494
Checklist
cargo fmt,cargo clippy --all-targets,cargo build --releaseandcargo testand fixed any generated errors!Note: if you locally don't get any errors, but GitHub Actions fails (especially at
clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.