Introduce SideEffect
#75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please start reviewing after #69.
I've added the SideEffect enum. In the current implementation, only
None,Read,Writecan be specified.Readcan be analogized to reading from memory. While it does not affect the state, it indicates that it can be influenced by the state.Writecan be analogized to writing to memory, and it affects the state.This is a very simple model, but it provides minimal necessary information for several optimizations, such as ADCE (Aggressive Dead Code Elimination) and instruction reordering, which I feel can have a relatively significant impact.
In the future, I would like to have a more rigorous model, and I plan to work on that in collaboration with Lane.