gocode: switch to https://github.com/mdempsky/gocode #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsf/gocode is not working well with Go 1.10. I just encountered it myself again. The author of original gocode also states and recommends the mdempsky/gocode fork over nsf/gocode: https://github.com/nsf/gocode#an-autocompletion-daemon-for-the-go-programming-language We actually [moved once](#1814), but because we didn't removed the obsolote settings, we weren't prepared for issues that were [reported](#1817), and hence [reverted it back](#1823) This PR also removes all settings. The reason is that the new gocode doesn't support settings anymore. The author decided not the support it. * For `autobuild`, this was removed because the author believe it's not worth tackling it inside `gocode`: mdempsky/gocode#13 * For `propose builtins`, this is actually still supported but disabled in the source code, we need to add it back again in the future: mdempsky/gocode@787cfae * For `unimported packages`: this was just removed and I couldn't find upcoming plans for it Going forward this package seems to be more stable and is a better bet. Most important, as I stated nfs/gocode is not 1.10 compatible and the author has no intentions to fix it.
|
lgtm |
This was referenced Jun 7, 2018
|
I tested this poorly before merging and subsequently found problems. The merge has been reverted, and a new PR is open with these same changes at #1853. |
|
Could you write what these problems are? Would be helpful to fix those. I'm using it since I've switched it and it was working well. |
|
I've started documenting on #1853. Let's move to there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nsf/gocode is not working well with Go 1.10. I just encountered it myself again. The author of original gocode also states and recommends the mdempsky/gocode fork over nsf/gocode: https://github.com/nsf/gocode#an-autocompletion-daemon-for-the-go-programming-language
We actually moved once, but because we didn't removed the obsolote settings, we weren't prepared for issues that were reported, and hence reverted it back
This PR also removes all settings. The reason is that the new gocode doesn't support settings anymore. The author decided not the support it.
autobuild, this was removed because the author believe it's notworth tackling it inside
gocode: auto install doesn't always work mdempsky/gocode#13propose builtins, this is actually still supported but disabled inthe source code, we need to add it back again in the future:
mdempsky/gocode@787cfae
unimported packages: this was just removed and I couldn't findupcoming plans for it
Going forward this package seems to be more stable and is a better bet. Most important, as I stated nfs/gocode is not 1.10 compatible and the author has no intentions to fix it.