Skip to content

Commit

Permalink
Added node version requirement for running the test.
Browse files Browse the repository at this point in the history
Added "engines" key to package.json.
Updated readme.md to document the requirement.
  • Loading branch information
johnhelmuth committed Jul 9, 2024
1 parent b04e8f9 commit 8b3414d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
"type": "git",
"url": "git+https://github.com/fate-srd/fate-product-list.git"
},
"engines": {
"node": "20.x"
},
"author": "amazingrando",
"license": "ISC",
"bugs": {
Expand Down
3 changes: 2 additions & 1 deletion readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ The submission will be reviewed and added to the Fate SRD. This usually happens
If you are comfortable with editing files and git/Github, you may [create a pull request](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request). It will be reviewed and added to the site.

There is a Github check configured to ensure the CSV file is in the expected order. This check is implemented a small
Javascript script that runs under [Nodejs](https://nodejs.org/) version 20.x. (The code will probably run under older versions, too.)
Javascript script that runs under [Nodejs](https://nodejs.org/) version 20.x, which is required. You will get a warning
from `npm` if you try this with older versions of Nodejs.

To check the CSV file order locally, before you push your changes to Github, you must have a current version of Nodejs
installed, then run the following commands.
Expand Down

0 comments on commit 8b3414d

Please sign in to comment.