Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new] Add a training trick #131

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[new] Add a training trick #131

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0378545
Update trainer.py
LindaCY Jan 19, 2019
fa300ce
Merge branch 'master' into patch-1
FengZiYjun Feb 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 35 additions & 3 deletions fastNLP/core/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

class Trainer(object):
def __init__(self, train_data, model, loss=None, metrics=None, n_epochs=3, batch_size=32, print_every=50,
validate_every=-1, dev_data=None, save_path=None, optimizer=Adam(lr=0.01, weight_decay=0),
validate_every=-1, dev_data=None, save_path=None, optimizer=Adam(lr=0.01, weight_decay=0), halve_lr_epochs=-1,
check_code_level=0, metric_key=None, sampler=RandomSampler(), use_tqdm=True, use_cuda=False,
callbacks=None):
"""
Expand All @@ -49,6 +49,7 @@ def __init__(self, train_data, model, loss=None, metrics=None, n_epochs=3, batch
:param bool use_cuda: whether to use CUDA in training.
:param str save_path: file path to save models
:param Optimizer optimizer: an optimizer object
:param halve_lr_epochs: halve the learning rate if not imporving for [halve_lr_epochs] epochs. Default: -1 (never use it)
:param int check_code_level: level of FastNLP code checker. -1: don't check, 0: ignore. 1: warning. 2: strict.\\
`ignore` will not check unused field; `warning` when warn if some field are not used; `strict` means
it will raise error if some field are not used.
Expand Down Expand Up @@ -106,6 +107,7 @@ def __init__(self, train_data, model, loss=None, metrics=None, n_epochs=3, batch
self.dev_data = dev_data # If None, No validation.
self.model = model
self.losser = losser
self.halve_lr_epochs = halve_lr_epochs
self.metrics = metrics
self.n_epochs = int(n_epochs)
self.batch_size = int(batch_size)
Expand All @@ -124,6 +126,9 @@ def __init__(self, train_data, model, loss=None, metrics=None, n_epochs=3, batch

self.use_tqdm = use_tqdm
self.print_every = abs(self.print_every)

for group in self.optimizer.param_groups:
self.lr = group['lr']

if self.dev_data is not None:
self.tester = Tester(model=self.model,
Expand Down Expand Up @@ -228,6 +233,7 @@ def _train(self):
else:
inner_tqdm = tqdm
self.step = 0
self.bad_valid = 0
start = time.time()
data_iterator = Batch(self.train_data, batch_size=self.batch_size, sampler=self.sampler, as_numpy=False)
total_steps = data_iterator.num_batches * self.n_epochs
Expand Down Expand Up @@ -258,8 +264,10 @@ def _train(self):
self._update()
# lr scheduler; lr_finder; one_cycle
self.callback_manager.after_step(self.optimizer)


# Write the training loss summary
self._summary_writer.add_scalar("loss", loss.item(), global_step=self.step)

for name, param in self.model.named_parameters():
if param.requires_grad:
self._summary_writer.add_scalar(name + "_mean", param.mean(), global_step=self.step)
Expand Down Expand Up @@ -316,6 +324,24 @@ def _do_validation(self, epoch, step):
self.best_dev_perf = res
self.best_dev_epoch = epoch
self.best_dev_step = step

# halve the learning rate if not improving for [halve_lr_epochs] epochs, and restart training from the best model.
else:
self.bad_valid += 1
if self.halve_lr_epochs != -1:
if self.bad_valid >= self.halve_lr_epochs:
self.lr = self.lr / 2.0
print("halve learning rate to {}".format(self.lr))
model_name = "best_" + "_".join([self.model.__class__.__name__, self.metric_key, self.start_time])
load_succeed = self._load_model(self.model, model_name)
if load_succeed:
print("Reloaded the best model.")
else:
print("Fail to reload best model.")
self._set_lr(self.optimizer, self.lr)
self.bad_valid = 0
print("bad valid: {}".format(self.bad_valid))

# get validation results; adjust optimizer
self.callback_manager.after_valid(res, self.metric_key, self.optimizer)
return res
Expand Down Expand Up @@ -409,7 +435,13 @@ def _better_eval_result(self, metrics):
else:
is_better = False
return is_better


def _set_lr(self, optimizer, lr):
# if self.optimizer == "YFOptimizer":
# optimizer.set_lr_factor(lr)
# else:
for group in optimizer.param_groups:
group['lr'] = lr

DEFAULT_CHECK_BATCH_SIZE = 2
DEFAULT_CHECK_NUM_BATCH = 2
Expand Down