Refactor: custom fastn_core::http::Response for fastn_core::serve
#2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`actix_web::HttpResponse` aka `fastn_core::http::Response` is not `Send` which makes it impossible to share it across threads. A direct downside of this is that we can't use a function which uses this type in a `tokio::spawn` because it required types to implement `Send`. A custom `fastn_core::http::Response` is added which is `Send` and used by the `fastn_core::serve` function. A `fastn_core::serve_actix` is also introduced which is a direct replacement for the old `fastn_core::serve`. This will allow us to, for example, use `fastn_core::serve` in a background task to update the cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actix_web::HttpResponseakafastn_core::http::Responseis notSendwhich makes it impossible to share it across threads. A direct downside of this is that we can't use a function which uses this type in atokio::spawnbecause it required types to implementSend.A custom
fastn_core::http::Responseis added which isSendand used by thefastn_core::servefunction. Afastn_core::serve_actixis also introduced which is a direct replacement for the oldfastn_core::serve.This will allow us to, for example, use
fastn_core::servein a background task to update the cache.