Auth/reset password and some auth changes #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move all handled routes to auth/urls.rs
don't need it, we can get the same result in two handlers and fewer redirects
this id is required by request.ud()
siddhantk232
added a commit
to siddhantk232/fastn-test-multiauth
that referenced
this pull request
Feb 20, 2024
siddhantk232
changed the title
|
@siddhantk232 there are some conflicts, please resolve. We have switched to using |
|
There's a way to disable sending emails in dev mode (using |
`/-/auth/create-account/` redirects to this route for sending email. users can also use this to request email again in case they did not receive it the first time
Heulitig
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a reset-password feature:
/-/auth/set-password//-/auth/forgot-password/. This sends an email with a link to set their password.Auth changes
/-/auth/create-account/: requires two new json body params,password2andaccept_terms. See the integration tests to learn what has changes in request body./-/auth/create-account/: redirect to/-/auth/resend-confirmation-email/on successful requests. This same route can be used to re-request confirmation emails in cases where user does not receive email.FASTN_ENABLE_EMAIL: new environment variable for use during development. This will be used to log emails to the console instead of actually sending it. This removes the need ofFASTN_SMTP*environment variables.req_config.request.ud()checks on server session before returning the user. This enables invalidation of logged in users on password reset.Refactor
Routeenum to keep track of auth related routes.What happens when a github user tried to reset their password?
The
/-/auth/set-password, used when authenticated, converts their github oauth account to a normal email_password account. After doing this, they can use both the github login and the email_password login method.Same goes for
/-/auth/forgot-password/, entering their github username/email will send an email with a link to set their password. Check https://github.com/siddhantk232/fastn-test-multiauth to test things out.