Refactor: Config generation and Dependency Resolution #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitu
reviewed
Jan 29, 2024
| @@ -60,6 +60,9 @@ async fn fastn_core_commands(matches: &clap::ArgMatches) -> fastn_core::Result<( | |||
| return fastn_core::create_package(name, path, download_base_url).await; | |||
| } | |||
|
|
|||
| let current_dir: camino::Utf8PathBuf = std::env::current_dir()?.canonicalize()?.try_into()?; | |||
| let ds = fastn_ds::DocumentStore::new(current_dir); | |||
|
|
|||
| let mut config = fastn_core::Config::read_current(true).await?; | |||
There was a problem hiding this comment.
You should not use read_current if you have a handle to ds.
amitu
reviewed
Jan 29, 2024
Comment on lines
-83
to
+86
| fastn_update::update(&config, offline).await?; | ||
| fastn_update::update(&ds, offline).await?; |
There was a problem hiding this comment.
Since config is not needed by fastn_update, we can re-order this function to not construct config before calling this.
|
Closed in favour of #1751 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring how config is generated and dependency packages are handled.
Discussion: https://github.com/FifthTry/business/discussions/308