Prevent internal class names from being removed #1467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the Issue?
The issue is that when using the
classes
header to set custom CSS class names, the class names of the kernel elements are being removed.How to Replicate
fastn code:
Expected Output:
Actual Output:
Proposed Solution
In
fastn-js/js/dom.js
, we can create a map of class names calledfastn_dom.InternalClass
that will be used by kernel components. Then, in thefastn_utils.removeNonFastnClasses
function, we can check if the className that is going to be removed is not one of those class names.