removing controller stuff and .d files from release #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Upadhyay <[email protected]>
|
@harshdoesdev can you take a look at this, and merge this after fastn-stack/fastn.com#522 is merged and deployed. No need to build controller binaries also as they are not supported. |
harshdoesdev
approved these changes
Nov 7, 2023
harshdoesdev
added a commit
that referenced
this pull request
Nov 7, 2023
This reverts commit d35198a.
|
@amitu it seems like there is some issue related to fbt test cases. the release was created on my forked PR, but the test failed. |
|
My latest PR got merged, and it had error. I had enabled auto merge assuming it will auto merge when all criteria's (approval and test passing) is met it will merge but github merged only after approval criteria got met. Could be that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.