Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fastn tutor part tres #1434

Merged
merged 37 commits into from
Nov 7, 2023
Merged

fastn tutor part tres #1434

merged 37 commits into from
Nov 7, 2023

Conversation

amitu
Copy link
Contributor

@amitu amitu commented Oct 27, 2023 •
edited
Loading

Docs

  • font issue

amitu and others added 20 commits October 27, 2023 21:57
@Arpita-Jaiswal
Copy link
Contributor

@amitu fonts are not working

@amitu
Copy link
Contributor Author

amitu commented Nov 4, 2023

@Arpita-Jaiswal its quite odd, the tests are passing on my machine but failing on Github CI.

@Arpita-Jaiswal
Copy link
Contributor

Blocked on roles/font's not working

@Arpita-Jaiswal
Copy link
Contributor

@amitu I think font is fixed. I am building fastn.com. Lets see.

@amitu
Copy link
Contributor Author

amitu commented Nov 6, 2023

@Arpita-Jaiswal awesome! Thanks :-)

@amitu
Copy link
Contributor Author

amitu commented Nov 6, 2023

@Arpita-Jaiswal how do we test this further? I want to merge it but it was a drastic PR. One option we just merge it, fastn.com seems to be working (or we will soon find out if something is broken on fastn.com).

@Arpita-Jaiswal
Copy link
Contributor

@amitu fastn build is still failing for font, fastn serve is now working

@Arpita-Jaiswal Arpita-Jaiswal merged commit 4af75a8 into main Nov 7, 2023
1 check passed
@Arpita-Jaiswal Arpita-Jaiswal deleted the tutor_3 branch November 7, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arpita-Jaiswal Arpita-Jaiswal Arpita-Jaiswal approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amitu @Arpita-Jaiswal