[WIP] Nix support on mac (requires testing) #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mac support requires testing! - use lib.cleanSource to stop unnecessary nix builds - rename `fastnp` to fastn
|
@siddhantk232 I am getting the following: |
|
I tried adding: buildInput = with pkgs; lib.optionals stdenv.isDarwin [ darwin.Security darwin.apple_sdk.frameworks.Security ];As recommended here: https://discourse.nixos.org/t/compile-a-rust-binary-on-macos-dbcrossbar/8612/2, but still same error. |
Could you try adding this to |
|
If that didn't work, then: buildInputs = with pkgs; lib.optionals stdenv.isDarwin [
darwin.Security darwin.apple_sdk.frameworks.Security
darwin.Security darwin.apple_sdk.frameworks.CoreFoundation
darwin.Security darwin.apple_sdk.frameworks.CoreServices
darwin.Security darwin.apple_sdk.frameworks.SystemConfiguration
];ps: I have no idea what I'm suggesting here 😑 |
|
I think I've made a typo in |
|
Tried this, same problem :-( buildInputs = with pkgs; lib.optionals stdenv.isDarwin [ darwin.Security ]; |
|
This worked! nix run . -- --version
warning: Git tree '/Users/amitu/Projects/fastn' is dirty
fastn: FTD Package Manager 0.3.76diff --git a/flake.nix b/flake.nix
index 0d28434bf..4cde95118 100644
--- a/flake.nix
+++ b/flake.nix
@@ -39,7 +39,12 @@
openssl.dev
] ++ lib.optionals stdenv.isDarwin [ xcbuild ];
- buildInput = with pkgs; lib.optionals stdenv.isDarwin [ darwin.Security ];
+ buildInputs = with pkgs; lib.optionals stdenv.isDarwin [
+ darwin.Security darwin.apple_sdk.frameworks.Security
+ darwin.Security darwin.apple_sdk.frameworks.CoreFoundation
+ darwin.Security darwin.apple_sdk.frameworks.CoreServices
+ darwin.Security darwin.apple_sdk.frameworks.SystemConfiguration
+ ];
};
in
rec { |
|
This works too: diff --git a/flake.nix b/flake.nix
index 0d28434bf..ad44b8ebd 100644
--- a/flake.nix
+++ b/flake.nix
@@ -39,7 +39,9 @@
openssl.dev
] ++ lib.optionals stdenv.isDarwin [ xcbuild ];
- buildInput = with pkgs; lib.optionals stdenv.isDarwin [ darwin.Security ];
+ buildInputs = with pkgs; lib.optionals stdenv.isDarwin [
+ darwin.apple_sdk.frameworks.SystemConfiguration
+ ];
};
in
rec { |
amitu
reviewed
Oct 23, 2023
amitu
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
darwin.Securityandxcbuildwhich should fix #1401.Tested on linux (NixOS) with:
nix build .Required testing on a mac, run
nix build .ornix run .with this branch checked out before merging this PR.Upon failure, please include the full log. Nix will mention the command to get the full log at the end of the error message.
Some QOL changes have also been made: