Default value for fit property set to cover

[harshdoesdev]

Default fit property if both width and height are defined

Example:

-- ftd.column:
padding.rem: 2
spacing.fixed.rem: 1

;; no default value will be assigned to `fit`

-- ftd.text: 1. no default value will be assigned to `fit`

-- ftd.image:
src: https://picsum.photos/800/600




;; no default value will be assigned to `fit` if just width is defined

-- ftd.text: 2. no default value will be assigned to `fit` if just width is defined

-- ftd.image:
src: https://picsum.photos/800/600
width.fixed.px: 300




;; no default value will be assigned to `fit` if just height is defined

-- ftd.text: 3. no default value will be assigned to `fit` if just height is defined

-- ftd.image:
src: https://picsum.photos/800/600
height.fixed.px: 350




;; `fit` will be set to `cover`

-- ftd.text: 4. `fit` will be set to `cover`

-- ftd.image:
src: https://picsum.photos/800/600
width.fixed.px: 300
height.fixed.px: 350



;; user defined `fit` property will override the default one

-- ftd.text: 5. user defined `fit` property will override the default one

-- ftd.image:
src: https://picsum.photos/800/600
width.fixed.px: 300
height.fixed.px: 350
fit: contain

-- end: ftd.column

Output:

[amitu]

@harshdoesdev I do not understand why are you implementing Default fit property if both width and height are defined and not default value of cover is fit. Is there any harm in using fit if both are not specified? If neither is specified?

If there is no harm the implement the simpler logic. If there is the harm then demonstrate the harm first.

[Heulitig]

This has unexpected behavior in certain images used in fastn.com and their invocation parameters will have to be changed to make those look unchanged. So closing this PR (as it could affect UI behavior in already used ftd.image's in fastn packages).

[amitu]

@harshdoesdev let's do this when we have edition feature implemented, and we create our next edition. I have added it to list of things we want to do on next edition: https://fastn.com/d/next-edition/.