prevent undefined from getting printed in markdown text (#1379)

* prevents undefined from getting printed in markdown * fix all tests
fastn-stack · Oct 12, 2023 · bf7f72b · bf7f72b
1 parent 510d07c
commit bf7f72b
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 3 deletions.
diff --git a/fastn-js/js/dom.js b/fastn-js/js/dom.js
@@ -1883,7 +1883,9 @@ class Node2 {
                 staticValue = this.#node.innerHTML;
             }
             staticValue = fastn_utils.process_post_markdown(this.#node, staticValue);
-            this.#node.innerHTML = staticValue;
+            if(!fastn_utils.isNull(staticValue)) {
+                this.#node.innerHTML = staticValue;
+            }
         } else {
             throw ("invalid fastn_dom.PropertyKind: " + kind);
         }

diff --git a/ftd/t/js/21-markdown.ftd b/ftd/t/js/21-markdown.ftd
@@ -3,3 +3,16 @@
 # Marked in the browser
 
 Rendered by **marked**.
+
+-- component markdown:
+body string text:
+
+-- ftd.text:
+text: $markdown.text
+
+-- end: markdown
+
+-- markdown:
+
+;; COMMENT NEXT LINE
+;; Go to the [new page](/new-page/).
diff --git a/ftd/t/js/21-markdown.html b/ftd/t/js/21-markdown.html
diff --git a/ftd/t/js/63-external-js.html b/ftd/t/js/63-external-js.html