-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
document fastn-stack/fastn#1425
@siddhantk232 is attempting to deploy a commit to the fifthtry Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@siddhantk232 this looks good so far. I was jus thinking maybe we should document all our environment variables in this file, currently we have documented a few in /sql/. Let's create a component for every environment variable, the component will contain the docs for that variable, put the definition of the component in the Eg,
And ftd-host/pg.ftd contains:
[1]: our component definition currently only accept one immediate child element, this is a problem as in this case the ftd.column we used resets the spacing between children (we can make it inherit the spacing, but we still have to create a wrapper div), it also does not use full width by default etc. I am not fond of this wrapper, and want to allow our components to have any number of children, and have fastn do the right thing. [2]: when importing we should use the proper url of a document or the file path, currently only file path urls are allowed. |
@amitu please review this latest commit and let me know if I missed anything. |
document fastn-stack/fastn#1425
Rendered