Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/fix: Deploying websites using Custom Domain #8

Closed

Conversation

ayushsoni1010
Copy link

@ayushsoni1010 ayushsoni1010 commented May 22, 2023

#6 is fixed by this PR changes

@amitu
Copy link
Collaborator

amitu commented May 22, 2023

@ayushsoni1010, the PR has changed related to your repo, please undo them. Also instead of instruction, write a shell script which does the right thing. Put the script in .github/ and call it from your workflow.

@ayushsoni1010
Copy link
Author

Alright, I will work on it

@amitu
Copy link
Collaborator

amitu commented May 29, 2023

@ayushsoni1010, @Arpita-Jaiswal, we need this soonish.

@gsalunke
Copy link
Contributor

gsalunke commented Jun 5, 2023

@ayushsoni1010
For now I have added the commented one via this commit:
1f7d111

When the shell-script (#8 (comment)) is ready plz raise new PR.

CC: @amitu @Arpita-Jaiswal @Heulitig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants