cdata codegen with eager outputs, part 2 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally this doesn't matter, because the expected API use is based on code generation rather than heavily using `fsm_exec`, but we are calling fsm_exec to check that the combined DFAs still match all of their original regexes. This is very expensive. (It similarly gets very cumbersome during fuzzing.) A better way to address this long-term is tracking on the FSM whether it's result of fsm_determinise (and optionally fsm_minimise), and updating that info to indicate that it reverted to an NFA if any other operations modify the FSM states/edges. That's outside the scope of this PR though.
Previously `AMBIG_NONE` was missing the closing curly brace but the other variants added it. All three need it, so it's cleaner to move it outside the switch case. Also, make AMBIG_NONE output `(void)endid_base;`, because otherwise it leads to a warning about the unused variable. (It's probably not worth complicating the output template further to avoid using it in the first place here.)
cxreg
approved these changes
Oct 14, 2024
silentbicycle
deleted the
sv/add-cdata-codegen-with-eager-outputs-part-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXPENSIVE_CHECKSwrapper to fsm_exec, this means minutes vs. HOURS for this build.AMBIG_MULTIvs.AMBIG_NONE, etc. This fixes a warning and bad bracing.