Update StarlingMonkey to pull in PBL+weval updates in SpiderMonkey. #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR pulls in bytecodealliance/StarlingMonkey#106, which in turn pulls in bytecodealliance/spidermonkey-wasi-embedding#21, which in turn pulls in bytecodealliance/gecko-dev#57, to fix a bug in weval'd PBL execution (AOT compilation mode) for `TableSwitch` opcodes.
guybedford
approved these changes
Aug 7, 2024
JakeChampion
approved these changes
Aug 7, 2024
cfallin
force-pushed
the
cfallin/update-sm
branch
from
14fbb0b
to
2efe1d7
Compare
cfallin
force-pushed
the
cfallin/update-sm
branch
from
2efe1d7
to
1bc9f08
Compare
|
I added a CI job to test Web Platform Tests under AOT compilation (weval) and it passes now after these fixes! |
|
Can confirm it all passes for me also, this is fab! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls in bytecodealliance/StarlingMonkey#106, which in turn pulls in bytecodealliance/spidermonkey-wasi-embedding#21, which in turn pulls in bytecodealliance/gecko-dev#57, to fix a bug in weval'd PBL execution (AOT compilation mode) for
TableSwitchopcodes.