Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update wpt submodule and url crate #603

Merged
merged 3 commits into from
Aug 10, 2023
Merged

update wpt submodule and url crate #603

merged 3 commits into from
Aug 10, 2023

Conversation

JakeChampion
Copy link
Contributor

The wpt update brings in more tests
The url crate update passes some more of the url tests 😄

@JakeChampion JakeChampion marked this pull request as ready for review July 21, 2023 23:36
Copy link
Contributor

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of new failures in addition to the new passing tests, should we be spend some time investigating to see if there are any quick fixes?

@JakeChampion
Copy link
Contributor Author

There's a lot of new failures in addition to the new passing tests, should we be spend some time investigating to see if there are any quick fixes?

I think once the rust-url project is in a better place for contribution we should definitely help out - perhaps we can help with the current effort to make contributions easier

@JakeChampion JakeChampion merged commit faef96d into main Aug 10, 2023
81 checks passed
@JakeChampion JakeChampion deleted the jake/wpt branch August 10, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants