Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AOT compilation: rename flag; no longer experimental. #1033

Merged
merged 2 commits into from
Nov 5, 2024
Merged

AOT compilation: rename flag; no longer experimental. #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3346191
AOT compilation: rename flag; no longer experimental.
cfallin Nov 4, 2024
5867e25
run formatter.
cfallin Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions integration-tests/cli/help.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ test('--help should return help on stdout and zero exit code', async function (t
'--engine-wasm <engine-wasm> The JS engine Wasm file path',
'--module-mode [experimental] Run all sources as native modules,',
'with full error stack support.',
'--enable-experimental-aot Enable experimental AOT compilation for performance',
'--enable-aot Enable AOT compilation for performance',
'--enable-experimental-high-resolution-time-methods Enable experimental high-resolution fastly.now() method',
'--enable-experimental-top-level-await Enable experimental top level await',
'ARGS:',
Expand Down Expand Up @@ -61,7 +61,7 @@ test('-h should return help on stdout and zero exit code', async function (t) {
'--engine-wasm <engine-wasm> The JS engine Wasm file path',
'--module-mode [experimental] Run all sources as native modules,',
'with full error stack support.',
'--enable-experimental-aot Enable experimental AOT compilation for performance',
'--enable-aot Enable AOT compilation for performance',
'--enable-experimental-high-resolution-time-methods Enable experimental high-resolution fastly.now() method',
'--enable-experimental-top-level-await Enable experimental top level await',
'ARGS:',
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/js-compute/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ const config = TOML.parse(
config.name = serviceName;
if (aot) {
const buildArgs = config.scripts.build.split(' ');
buildArgs.splice(-1, null, '--enable-experimental-aot');
buildArgs.splice(-1, null, '--enable-aot');
config.scripts.build = buildArgs.join(' ');
}
if (debugBuild) {
Expand Down
8 changes: 8 additions & 0 deletions src/parseInputs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,15 @@ export async function parseInputs(cliInputs) {
bundle = true;
break;
}
case '--enable-aot': {
enableAOT = true;
break;
}
case '--enable-experimental-aot': {
console.error(
'Warning: --enable-experimental-aot flag is now --enable-aot. The old flag continues\n' +
'to work for now, but please update your build invocation!',
);
enableAOT = true;
break;
}
Expand Down
2 changes: 1 addition & 1 deletion src/printHelp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ OPTIONS:
--engine-wasm <engine-wasm> The JS engine Wasm file path
--module-mode [experimental] Run all sources as native modules,
with full error stack support.
--enable-experimental-aot Enable experimental AOT compilation for performance
--enable-aot Enable AOT compilation for performance
--enable-experimental-high-resolution-time-methods Enable experimental high-resolution fastly.now() method
--enable-experimental-top-level-await Enable experimental top level await

Expand Down
Loading