fix!: immutable headers guards for incoming response and downstream request #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will wait to land this until we make the next major release. |
guybedford
force-pushed
the
immutable-headers
branch
from
35575a6
to
913751b
Compare
guybedford
force-pushed
the
main
branch
4 times, most recently
from
6aff377
to
206a60e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements immutable headers guards for the fetch event request, and any
fetch()responses.With this change, trying to set a header on one of these will throw a TypeError as is correct per the fetch and service worker specs.
Resolves #992.