fix: ensure headers are set on first commit (#1036)

fastly · Nov 7, 2024 · d622799 · d622799
1 parent 5c3eba0
commit d622799
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/runtime/fastly/builtins/body.cpp b/runtime/fastly/builtins/body.cpp
@@ -4,10 +4,6 @@
 #include <optional>
 #include <string>
 
-// TODO(GB) remove once https://github.com/bytecodealliance/StarlingMonkey/pull/75 lands
-// clang-format off
-#include "builtin.h"
-// clang-format on
 #include "../../../StarlingMonkey/builtins/web/fetch/fetch-errors.h"
 #include "../../../StarlingMonkey/builtins/web/streams/native-stream-source.h"
 #include "../../../StarlingMonkey/builtins/web/url.h"

diff --git a/runtime/fastly/host-api/host_api.cpp b/runtime/fastly/host-api/host_api.cpp
@@ -574,8 +574,18 @@ Result<HttpHeaders *> HttpHeaders::FromEntries(vector<tuple<HostString, HostStri
 Result<Void>
 write_headers(HttpHeaders *headers,
               std::vector<std::tuple<host_api::HostString, host_api::HostString>> &list) {
+  std::vector<std::string_view> seen;
+  seen.reserve(list.size());
+  host_api::Result<host_api::Void> res;
   for (const auto &[name, value] : list) {
-    auto res = headers->append(name, value);
+    if (std::find(seen.begin(), seen.end(), name) == seen.end()) {
+      // first time seeing a header -> use set in case of existing values on the handle
+      res = headers->set(name, value);
+      seen.push_back(name);
+    } else {
+      // seen before -> use append
+      res = headers->append(name, value);
+    }
     if (res.is_err()) {
       return res;
     }