Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update product cache to use /entitlements endpoint #154

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dinoboy197
Copy link

@dinoboy197 dinoboy197 commented Jan 5, 2024

Switch to use /entitlements endpoint rather than /entitled-products.

Do not merge or create a release from this draft. This is for testing purposes only at the moment.

Copy link
Member

@leklund leklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple style comments but this is looking good. I also want to make sure the product names are correct (I think so but I want to check that with you).

pkg/api/product_cache.go Outdated Show resolved Hide resolved
pkg/api/product_cache.go Outdated Show resolved Hide resolved
pkg/api/product_cache_test.go Outdated Show resolved Hide resolved
pkg/api/product_cache.go Outdated Show resolved Hide resolved
@leklund
Copy link
Member

leklund commented Jan 12, 2024

This looks great! Let me know when the new endpoint is ready to go and I can test this branch locally. Thanks for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants