Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for reading secrets from a JSON file #428

Merged
merged 2 commits into from
Sep 24, 2024
Merged

add support for reading secrets from a JSON file #428

merged 2 commits into from
Sep 24, 2024

Conversation

joeshaw
Copy link
Member

@joeshaw joeshaw commented Sep 16, 2024

This uses the same format as for the KV store, introduced in #365.

Fixes #364.

@joeshaw
add support for reading secrets from a JSON file
233dcae 
This uses the same format as for the KV store, introduced in #365.

Fixes #364.
cee-dub
cee-dub reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@cee-dub cee-dub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple spelling corrections from me. I didn’t see any obvious issues with the Rust, but I’m still learning it, so I don’t feel qualified to give a ✅.

lib/src/config/secret_store.rs Outdated Show resolved Hide resolved
lib/src/config/secret_store.rs Outdated Show resolved Hide resolved
@joeshaw @cee-dub
typo fixes
86b648c 
Co-authored-by: Cameron Walters (cee-dub) <[email protected]>
@joeshaw joeshaw mentioned this pull request Sep 17, 2024
Open
ulyssa
ulyssa approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@ulyssa ulyssa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! ✨

@joeshaw joeshaw merged commit 3e839fe into main Sep 24, 2024
15 checks passed
@joeshaw joeshaw deleted the joeshaw/json-secret-store branch September 24, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-dub cee-dub cee-dub left review comments

@ulyssa ulyssa ulyssa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow JSON files as input for Secrets Stores and KVStores
3 participants
@joeshaw @cee-dub @ulyssa