Remove the trappable_error_type #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
force-pushed
the
trevor/no-trap-component-errors
branch
from
48312d2
to
61ef8ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
trappable_error_typeargument towasmtime::bindgen!became optional in wasmtime-21, and given that we never expect to trap in any of our host implementations, let's remove that additional complexity.The meat of this change is removing the custom
FastlyErrortype, and replacing it withtypes::Errorwhich is generated from compute.wit. This simplifies some functions like thev2suffixed request functions, but in most cases ended up being a renaming fromFastlyErrortotypes::Error.