Add delete_async hostcall for kv #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
computermouth
commented
Nov 10, 2023
There was a problem hiding this comment.
Not 100% sure about this change. I needed to differentiate the
impl From<PendingKvInsertTask> for AsyncItem
and
impl From<PendingKvDeleteTask> for AsyncItem
... traits, which couldn't be done with the type alias, so I went for the struct newtypes. Hopefully the new/task isn't too silly. It was either that or sprinkle some pub everywhere, figured this was more idiomatic.
There was a problem hiding this comment.
Yep, this is exactly the right thing to do. Not the prettiest, but things can get a bit messy when you go far enough with the type system :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested good on the local machine with an sdk which also has the hostcall