Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return a ValueAbsent for all the downstream-tls related functions instead of a NotAvailable #315

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Return a ValueAbsent for all the downstream-tls related functions instead of a NotAvailable #315

merged 3 commits into from
Apr 4, 2024

Commits on Mar 20, 2024

  1. Return a ValueAbsent for all the downstream-tls related functions 

    Currently these functions return a NotAvailable error, I believe this is because we don't support https within Viceroy.

We do support http though, and http is also supported on Fastly, this patch adds an implementation for the downstream-tls functions which is valid for http (non-tls) connections. As Viceroy does not yet support https, we could say this is a full implementation as-of-today. In the future if/when Viceroy supports https, we would need to come back to these functions and make them return the correct, expected values based on the incoming connection (tls or not).
    Jake Champion committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    6740bb8 View commit details
    Browse the repository at this point in the history

  2. Remove ja3 call in test as the current rust sdk will panic from that … 

    …call
    Jake Champion committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    37466e8 View commit details
    Browse the repository at this point in the history

  3. Add note that the test for get_tls_raw_client_certificate() on non-tl… 

    …s requests is commented out as it currently panics - we are waiting on a patch to land in the fastly crate to make it not panic in this situation
    Jake Champion authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    24d2774 View commit details
    Browse the repository at this point in the history