Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset the default value for grpc for static backends to false. #311

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

acw
Copy link
Contributor

@acw acw commented Sep 18, 2023

No description provided.

acfoltzer
acfoltzer previously approved these changes Sep 18, 2023
Copy link
Contributor

@acfoltzer acfoltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the subsequent PR to land tests for this new flag, can we include a test to avoid a regression?

Copy link
Contributor

@acfoltzer acfoltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️

@acw acw merged commit a3fa5dd into main Sep 18, 2023
7 checks passed
@acw acw deleted the awick/fix-default-backend-grpc branch September 18, 2023 18:19
cmckendry pushed a commit to 1stdibs/Viceroy that referenced this pull request Feb 8, 2024
…tly#311)

* Reset the default value for `grpc` for backends to false.
* Update the CHANGELOG with the change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants