Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use t.error #322

Merged
merged 1 commit into from
Dec 25, 2023
Merged

test: use t.error #322

merged 1 commit into from
Dec 25, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Dec 25, 2023 •
edited
Loading

Detected by my citgm worfklow

I guess we now return null instead of undefined, so the tests fail. Fixing this.

Checklist

@Uzlopak Uzlopak requested a review from a team December 25, 2023 22:44
@Uzlopak Uzlopak mentioned this pull request Dec 25, 2023
Merged
4 tasks
gurgunday
gurgunday approved these changes Dec 25, 2023
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit 2ea577c into master Dec 25, 2023
21 checks passed
@Uzlopak Uzlopak deleted the use-t-error branch December 25, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @gurgunday