Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: local sign options overwrites global sign options #310

Merged
merged 2 commits into from
Oct 7, 2023
Merged

fix: local sign options overwrites global sign options #310

merged 2 commits into from
Oct 7, 2023

Conversation

mattiapv
Copy link
Contributor

@mattiapv mattiapv commented Oct 6, 2023

Closes #304

Checklist

jsumners
jsumners reviewed Oct 6, 2023
View reviewed changes
jwt.js Outdated Show resolved Hide resolved
jwt.js Outdated Show resolved Hide resolved
@mattiapv @jsumners
post review
5359436 
Co-authored-by: James Sumners <[email protected]>
mcollina
mcollina approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit dbed29f into fastify:master Oct 7, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsumners jsumners jsumners left review comments

@gurgunday gurgunday gurgunday approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Local sign options overwrites global sign options
4 participants
@mattiapv @mcollina @jsumners @gurgunday