Merge pull request #2 from JanHuang/0.1

0.1
fastdlabs · May 11, 2017 · 5dfa3c1 · 5dfa3c1
2 parents a83a7de + 449a4ce
commit 5dfa3c1
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 1 deletion.
diff --git a/src/ArrayObject.php b/src/ArrayObject.php
@@ -33,7 +33,12 @@ public function merge($array)
         $merge = function ($array1, $array2) use (&$merge) {
             foreach ($array2 as $key => $value) {
                 if (array_key_exists($key, $array1) && is_array($value)) {
-                    $array1[$key] = $merge($array1[$key], $array2[$key]);
+                    if (is_array($array1[$key])) {
+                        $array1[$key] = $merge($array1[$key], $value);
+                    } else {
+                        array_unshift($value, $array1[$key]);
+                        $array1[$key] = $value;
+                    }
                 } else {
                     $array1[$key] = $value;
                 }

diff --git a/tests/ArrayObjectTest.php b/tests/ArrayObjectTest.php
@@ -89,6 +89,35 @@ public function testMerge ()
                 ]
             ]
         ], $this->array->getArrayCopy());
+
+
+        $this->array->merge([
+            'foo' => null,
+        ]);
+
+        $this->array->merge([
+            'foo' => [
+                'bar' => 'var',
+            ],
+        ]);
+
+        $this->assertSame(
+            [
+                'foo' => [
+                    0 => NULL,
+                    'bar' => 'var',
+                ],
+                'foobar' => 'zyc',
+                'database' => [
+                    'host' => '127.0.0.1',
+                    'options' => [
+                        'foo' => 'bar',
+                        'foobar' => 'zyc',
+                    ],
+                ],
+            ],
+            $this->array->getArrayCopy()
+        );
     }
 
     public function testArrayKey()