Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fastai dependency #49

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tyoc213
Copy link

@tyoc213 tyoc213 commented Aug 27, 2020

Now fastai2 is just fastai

@tyoc213
Copy link
Author

tyoc213 commented Aug 27, 2020

I didnt do nbdev_build_docs because I see more changes that just the lines of fastai2 to fastai.

Also there are some test that dont past inside fastcore it seems?

@kevinbird15
Copy link

I see the same issue with the warning test failing. I can't figure out what that should be producing. Any idea what those commands should produce?

@tyoc213
Copy link
Author

tyoc213 commented Aug 28, 2020

@kevinbird15 dont know, will check tomorrow, today I just updated the example to use the dataset from pytorch voice comands, hope people dont mind.

@tyoc213
Copy link
Author

tyoc213 commented Aug 28, 2020

By the way, in the tutorial I need to change batch sizes from 512 and 1024 to 64, dont know if the last one I can put a bigger size, didnt try.

@hellno
Copy link

hellno commented Sep 5, 2020

Hi, would love to help with this. What is left to do to merge it to master?

@mogwai
Copy link
Member

mogwai commented Sep 5, 2020

We're going for restructure of the project without nbdev. They new project can be found here:

https://github.com/fastaudio/fastaudio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants