Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify pipeline patch #30

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

PranY
Copy link
Contributor

@PranY PranY commented Apr 3, 2020

The verify_pipeline method covers the known edge-cases for the transforms pipeline. The design is to introduce an extensible framework to check future cases.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@@ -49,6 +49,9 @@
"outputs": [],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The verify_pipeline function defined here should be instead on the Pipelines section, that is a couple of cells below. Also, it would be very helpful to include some examples, and you can add tests that it works using test_warns function from fastcore.


Reply via ReviewNB

@scart97
Copy link
Collaborator

scart97 commented Apr 11, 2020

The tests are breaking because of a problem while exporting the code from the notebooks. Please follow the instructions to fix it:

  • Install nbdev: pip install nbdev --upgrade
  • Install the git hooks (only need to do once): nbdev_install_git_hooks
  • Before each commit run the following commands:
pip install nbdev --upgrade
nbdev_clean_nbs
nbdev_build_lib
nbdev_build_docs
  • Optionally run nbdev_test_nbs to test the code

The instructions to contribute that are present on the repository at the moment are lacking, I will update them.

README.md Outdated Show resolved Hide resolved
@mogwai
Copy link
Member

mogwai commented Apr 14, 2020

The instructions to contribute that are present on the repository at the moment are lacking, I will update them.

Surely we ca add those the into the pre-commit hook?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants